Use connectTimeoutMS for connection establishment in maintenance TimeoutContext. #1777
Conversation
…out context. JAVA-5927
vbabanin
requested review from
nhachicha and
rozza
and removed request for
a team
|
@vbabanin lots of tests failing after this - are they related or transient? |
| */ | ||
| @Test | ||
| @DisplayName("Should throw MongoOperationTimeoutException when establishing connection in background if timeoutMs expired before starting connect") | ||
| public void shouldThrowMongoOperationTimeoutWhenEstablishingConnectionInBackgroundIfTimeoutMsExpiredBeforeStartingConnect() { |
There was a problem hiding this comment.
This appears to be failing in reactive streams only and is happy in sync. Does the test need tweaking?
There was a problem hiding this comment.
I replaced this prose-style test Should throw MongoOperationTimeoutException when establishing connection in background if timeoutMs expired before starting connect with a unit test for the sync driver. Helper for establishing SocketStream's already had this behaviour but no test.
The async implementation doesn’t have this and it’s not strictly required, since it’s unlikely anyone would specify such a low timeout (e.g. 1 ms) that would effectively prevent connections from being established.
...e/src/test/functional/com/mongodb/internal/connection/SocketStreamHelperSpecification.groovy
Outdated
Show resolved
Hide resolved
…n/SocketStreamHelperSpecification.groovy
JAVA-5927